On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote: > Please don't just blindly > follow checkpatch as it can give out erroneous information. > > Looking over most of this patch series it seems like it is taking > readability in the wrong direction and reducing the ability to maintain > the driver since this code has been "maintenance only" for some time > now. If somebody comes up with a legitimate fix for an issue at some > point in the future they will need to work around these patches in order > to back-port it into a stable release and that just hurts maintainability. > > I'd say this whole series should be rejected on the grounds that this > driver is mostly stable and should only really be modified for bug fixes > at this point. If we really need to go through and do a checkpatch > sweep we should probably just focus on serious errors only instead of > going astray and chasing down things that are false hits or minor issues > that are mostly a matter of preference.
Excellent advice. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
