On 10/19/15 3:37 AM, Kaixu Xia wrote:
+/* flags for PERF_EVENT_ARRAY maps*/
+enum {
+       BPF_EVENT_CTL_BIT_CUR = 0,
+       BPF_EVENT_CTL_BIT_ALL = 1,
+       __NR_BPF_EVENT_CTL_BITS,
+};
+
+#define        BPF_CTL_BIT_FLAG_MASK \
+       ((1ULL << __NR_BPF_EVENT_CTL_BITS) - 1)
+#define        BPF_CTL_BIT_DUMP_CUR \
+       (1ULL << BPF_EVENT_CTL_BIT_CUR)
+#define        BPF_CTL_BIT_DUMP_ALL \
+       (1ULL << BPF_EVENT_CTL_BIT_ALL)
+

the above shouldn't be part of uapi header. It can stay in bpf_trace.c
Just document these bits next to helper similar to skb_store_bytes()

The rest looks ok.
It still needs an ack from Peter for perf_event bits

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to