On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote:
> Broadcom ethernet driver for the new family of NetXtreme-C/E
> ethernet devices.
>
> v3:
> - Fixed 2 more sparse warnings.
> - Removed some unused structures in .h files.
>
> v2:
> - Fixed all kbuild test robot reported warnings.
> - Fixed many of the checkpatch.pl errors and warnings.
> - Fixed the Kconfig description.
>
> Acked-by: Eddie Wai <[email protected]>
> Acked-by: Jeffrey Huang <[email protected]>
> Signed-off-by: Prashant Sreedharan <[email protected]>
> Signed-off-by: Michael Chan <[email protected]>
...
Looks pretty good so far...
> + if (req.hwrm_intf_maj != resp->hwrm_intf_maj ||
> + req.hwrm_intf_min != resp->hwrm_intf_min ||
> + req.hwrm_intf_upd != resp->hwrm_intf_upd) {
> + netdev_warn(bp->dev, "HWRM interface %d.%d.%d does not match
> driver interface %d.%d.%d. Please update driver or firmware with matching
> interface versions.\n",
> + resp->hwrm_intf_maj, resp->hwrm_intf_min,
> + resp->hwrm_intf_upd, req.hwrm_intf_maj,
> + req.hwrm_intf_min, req.hwrm_intf_upd);
> + }
Any chance we could break that string and/or make it a bit shorter?
Thats a long one! (130+ characters)
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
