On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote: > With the previously introduced remove callback, add a > mv88e6xxx common remove function to cleanup all resources. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> > --- > drivers/net/dsa/mv88e6xxx.c | 18 ++++++++++++++++++ > drivers/net/dsa/mv88e6xxx.h | 2 ++ > 2 files changed, 20 insertions(+) > > diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c > index b1b14f5..6287096 100644 > --- a/drivers/net/dsa/mv88e6xxx.c > +++ b/drivers/net/dsa/mv88e6xxx.c > @@ -331,6 +331,16 @@ void mv88e6xxx_ppu_state_init(struct dsa_switch *ds) > ps->ppu_timer.function = mv88e6xxx_ppu_reenable_timer; > } > > +void mv88e6xxx_ppu_state_remove(struct dsa_switch *ds) > +{ > + struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > + > + del_timer_sync(&ps->ppu_timer); > + > + cancel_work_sync(&ps->bridge_work); > + flush_work(&ps->bridge_work); > +} > +
You add this function, but you don't use it anywhere? Also, why cancel bridge work, not ppu_work? Or has that been consolidated in some patch i'm missing? Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html