From: Jarod Wilson <ja...@redhat.com> Date: Tue, 3 Nov 2015 23:09:32 -0500
> With moving netdev_sync_lower_features() after the .ndo_set_features > calls, I neglected to verify that devices added *after* a flag had been > disabled on an upper device were properly added with that flag disabled as > well. This currently happens, because we exit __netdev_update_features() > when we see dev->features == features for the upper dev. We can retain the > optimization of leaving without calling .ndo_set_features with a bit of > tweaking and a goto here. > > Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features > down stack") ... > Reported-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > Signed-off-by: Jarod Wilson <ja...@redhat.com> > --- > v2: Based on suggestions from Alex, and with not changing err to ret, this > patch actually becomes quite minimal and doesn't ugly up the code much. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html