David Miller <da...@davemloft.net> writes: > From: Måns Rullgård <m...@mansr.com> > Date: Tue, 10 Nov 2015 20:53:19 +0000 > >> David Miller <da...@davemloft.net> writes: >> >>> From: Måns Rullgård <m...@mansr.com> >>> Date: Tue, 10 Nov 2015 18:05:15 +0000 >>> >>>> Because I haven't been following the netdev list closely for the last >>>> five years, and no documentation I read mentioned this function. I can >>>> certainly change it. >>> >>> It is always advisable to mimick what other drivers do and use them as >>> a reference, rather than depend upon documentation which by definition >>> is always going to be out of sync with the source tree. >> >> Sure. The trick is to pick the right driver(s) to use as reference. >> Quite a few of them don't use that function. > > If you really are stumped on this matter, start at least with the > ixgbe driver. In fact pretty much every Intel ethernet driver is > a reasonable reference. Others to check out are bnx2x and mlx5.
Even ixgbe uses napi_complete() while netdevice.h says one should "consider using napi_complete_done() instead." Did the author consider it and decide not to, or has the driver simply not been updated? As for the napi_gro_receive() function, calling that instead of netif_receive_skb() is easy enough, or are there other things I should be doing in addition? -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
