On Thu, Nov 19, 2015 at 12:29 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 19/11/15 04:26, Will Deacon wrote: ... >> /me waits for on-soc tulip integration. > > FWIW, this already happened, the ADMtek/Infineon ADM8668 actually > integrated a Tulip chip. I have not submitted these patches below from > the OpenWrt tree because the chip is barely used nowadays, and it was > only mostly popular with the Linksys WRTU54G. > > The patches could be made less intrusive if we did convert the pci_dma* > calls into regular DMA-API calls, which they are nowadays, oh well!
I agree. IIRC, there was no DMA-API when this driver was written. James Bottomley added DMA API later and there was no need to convert since Tulip devices were _only_ PCI at the time. > https://dev.openwrt.org/browser/trunk/target/linux/adm8668/patches-3.18/004-tulip_pci_split.patch In general this would be a reasonable patch to submit here with some caveats: 1) convert to DMA API (first patch) 2) add CONFIG_PCI code (second patch) to handle the remaining discovery and PCI Config space bits. Some additional minor refactoring of the code could convert this into a "multi-bus driver" if there is any system that could incorporate both a platform device and a PCI device. I expect the conversion to DMA API to be straight forward as the next patch shows: > https://dev.openwrt.org/browser/trunk/target/linux/adm8668/patches-3.18/005-tulip_platform.patch Split this patch into two parts: convert to DMA-API (first patch) and platform device support (third patch). Should be a "no brainer" to accept. Lastly, net/ethernet/dec/tulip driver is up for adoption. I've just been extremely lazy about updating the MAINTAINERS entry but will submit that shortly (apologies to Arndt for the bounced email - I know it's a bit disconcerting to see that.) I'm happy to continue review tulip code changes anyway. cheers, grant > -- > Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
