On Mon, Nov 23, 2015 at 1:53 PM, Tom Herbert <t...@herbertland.com> wrote: >> diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h >> index cb2f89f..72415aa 100644 >> --- a/include/net/udp_tunnel.h >> +++ b/include/net/udp_tunnel.h >> @@ -9,6 +9,12 @@ >> #include <net/addrconf.h> >> #endif >> >> +enum udp_tunnel_type { >> + UDP_TUNNEL_UNSPEC, >> + UDP_TUNNEL_VXLAN, >> + UDP_TUNNEL_GENEVE, >> +}; >> + > > Sorry, I still don't like this. Grant it least it gets rid of of VXLAN > specific ops, but the problem is there no such things as a common set > of encapsulations in the kernel (e.g. foo-over-udp adds a bunch of > encapsulations not represented here), no defined common set of device > functionality that needs this, and this precludes the use of the RX > accelerations to be available from a userpsace implementation.
Regardless, I think this is at least a good cleanup of what is already there compared to having VXLAN-specific NDOs. We can always add additional things in the future. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html