On Tue, Dec 01, 2015 at 02:49:02PM +0100, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > Implement basic procedures for joining/leaving port to/from LAG. That > includes HW setup of collector, core LAG mapping setup. > [...] > @@ -1937,6 +2153,18 @@ static int mlxsw_sp_netdevice_event(struct > notifier_block *unused, > mlxsw_sp_port->bridged = 0; > mlxsw_sp_master_bridge_dec(mlxsw_sp, upper_dev); > } > + } else if (netif_is_lag_master(upper_dev)) { > + if (info->linking) { > + err = mlxsw_sp_port_lag_join(mlxsw_sp_port, > + upper_dev); > + if (err) > + netdev_err(dev, "Failed to join link > aggregation\n"); > + } else { > + err = mlxsw_sp_port_lag_leave(mlxsw_sp_port, > + upper_dev); > + if (err) > + netdev_err(dev, "Failed to leave link > aggregation\n"); > + } > } > break; > }
If I'm reading this correctly, moving an offloaded port into a bond/team or changing configuration options isn't synchronous. It seems like the lack of immediate feedback to the caller is not desired. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html