>> + bool tns_mode:1;
>> + bool sqs_mode:1;
>These little refactors are creeping in your code without even being
mentioned in the commit message, this is not good practice.
Okay, will include these in the commit message.
>IMHO. Additionally, may be turn these two flags into something like:
>enum nicvf_mode {
> NICVF_BYPASS,
> NICVF_TNS,
> NICVF_SQS
>};
>? Anyway, these modes are mutually exclusive.
VF driver always assumed to be in BYPASS mode.
Will submit a seperate cleanup patch to get rid of 'tns_mode' boolean.
Thanks,
Sunil.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
