On 14.12.2015 18:06, Herbert Xu wrote:
> On Mon, Dec 14, 2015 at 05:55:25PM +0100, Hannes Frederic Sowa wrote:
>> portid may be 0, thus bound will set the flag to false for in-kernel
>> created netlink sockets.
>>
>> Fixes: da314c9923fed55 ("netlink: Replace rhash_portid with bound")
>> Cc: Herbert Xu <[email protected]>
>> Signed-off-by: Hannes Frederic Sowa <[email protected]>
>> ---
>> This patch should not affect anything and is just meant to close this
>> loophole in future. I based it on net, but you can also apply it to
>> net-next.
>
> Nack. The bound field only needs to be true for user-space sockets.
> So please explain why you need it to be true for kernel sockets.
I reviewed this very carefully and think this is currently a matter of
taste as it does not change current logic.
Otherwise I would recommend adding a "!!" to express that we actually
want bound set based on the portid value?
Bye,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
