On Thu, Dec 17, 2015 at 01:41:59PM +0100, Gregory CLEMENT wrote: > Hi Sudip, > > On jeu., déc. 17 2015, Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote: > > > mips allmodconfig build fails with the error: > > > > drivers/net/ethernet/cadence/macb.c: In function 'macb_probe': > > drivers/net/ethernet/cadence/macb.c:2908:2: error: implicit declaration of > > function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] > > bp->reset_gpio = devm_gpiod_get_optional(&bp->pdev->dev, "phy-reset", > > ^ > > drivers/net/ethernet/cadence/macb.c:2909:8: error: 'GPIOD_OUT_HIGH' > > undeclared (first use in this function) > > GPIOD_OUT_HIGH); > > ^ > > drivers/net/ethernet/cadence/macb.c:2909:8: note: each undeclared > > identifier is reported only once for each function it appears in > > drivers/net/ethernet/cadence/macb.c: In function 'macb_remove': > > drivers/net/ethernet/cadence/macb.c:2979:3: error: implicit declaration of > > function 'gpiod_set_value' [-Werror=implicit-function-declaration] > > gpiod_set_value(bp->reset_gpio, 0); > > ^ > > > > Add the proper header file to resolve it. > > > A proper fix already has been posted along with the proper device tree > bindinsg too: > http://marc.info/?l=linux-netdev&m=145034590619620&w=2
Thanks, just compiled with it and the build error for which I posted this patch is now gone. regards sudip -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html