On Sat, 2015-12-19 at 03:27 +0000, Ben Hutchings wrote:
> On Thu, 2015-12-17 at 06:51 +0000, kan.li...@intel.com wrote:
> > From: Kan Liang <kan.li...@intel.com>
> >
> > Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting.
> > The following patches will enable some SUB_COMMANDs for per queue
> > setting.
> >
> > Signed-off-by: Kan Liang <kan.li...@intel.com>
> > ---
> > include/uapi/linux/ethtool.h | 18 ++++++++++++++++++
> > net/core/ethtool.c | 17 +++++++++++++++++
> > 2 files changed, 35 insertions(+)
> >
> > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> > index cd16291..05bc92a 100644
> > --- a/include/uapi/linux/ethtool.h
> > +++ b/include/uapi/linux/ethtool.h
> > @@ -1144,6 +1144,22 @@ enum ethtool_sfeatures_retval_bits {
> > #define ETHTOOL_F_WISH (1 << ETHTOOL_F_WISH__BIT)
> > #define ETHTOOL_F_COMPAT (1 << ETHTOOL_F_COMPAT__BIT)
> >
> > +#define MAX_QUEUE 4096
> > +#define MAX_QUEUE_MASK (MAX_QUEUE / 64)
> > +
> > +/**
> > + * struct ethtool_per_queue_op - apply sub command to the queues in mask.
> > + * @cmd: ETHTOOL_PERQUEUE
> > + * @queue_mask: Mask the queues which sub command apply to
> > + * @sub_command: the sub command
> > + * @data: parameters of the command
[...]You also need to make it clear that there's a complete command structure following for each of the queues addressed, both for get and set. I.e. set does not apply the same settings to all queues. Ben. -- Ben Hutchings Always try to do things in chronological order; it's less confusing that way.
signature.asc
Description: This is a digitally signed message part
