The dirty index can be updated out of the loop where all the
tx resources are claimed. This will help on performances too.
Also a useless debug printk has been removed from the main loop.

Signed-off-by: Giuseppe Cavallaro <peppe.cavall...@st.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 230ded2..daa732f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1357,9 +1357,6 @@ static void stmmac_tx_clean(struct stmmac_priv *priv)
                        }
                        stmmac_get_tx_hwtstamp(priv, entry, skb);
                }
-               if (netif_msg_tx_done(priv))
-                       pr_debug("%s: curr %d, dirty %d\n", __func__,
-                                priv->cur_tx, priv->dirty_tx);
 
                if (likely(priv->tx_skbuff_dma[entry].buf)) {
                        if (priv->tx_skbuff_dma[entry].map_as_page)
@@ -1390,8 +1387,8 @@ static void stmmac_tx_clean(struct stmmac_priv *priv)
 
                if (++entry >= txsize)
                        entry = 0;
-               priv->dirty_tx = entry;
        }
+       priv->dirty_tx = entry;
 
        netdev_completed_queue(priv->dev, pkts_compl, bytes_compl);
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to