On 1/5/2016 4:29 AM, David Miller wrote:
From: Giuseppe Cavallaro <peppe.cavall...@st.com> Date: Mon, 4 Jan 2016 14:06:47 +0100@@ -81,7 +81,7 @@ static void stmmac_default_data(struct plat_stmmacenet_data *plat) plat->mdio_bus_data->phy_mask = 0; plat->dma_cfg->pbl = 32; - plat->dma_cfg->burst_len = DMA_AXI_BLEN_256; + /* TODO: AXI */ /* Set default value for multicast hash bins */ plat->multicast_filter_bins = HASH_TABLE_SIZE; @@ -115,8 +115,8 @@ static int quark_default_data(struct plat_stmmacenet_data *plat, plat->mdio_bus_data->phy_mask = 0; plat->dma_cfg->pbl = 16; - plat->dma_cfg->burst_len = DMA_AXI_BLEN_256; plat->dma_cfg->fixed_burst = 1; + /* AXI (TODO) */ /* Set default value for multicast hash bins */ plat->multicast_filter_bins = HASH_TABLE_SIZE;Isn't this going to cause a regression for some things?
trying to rebuild the story of this setting, I understand it was added to align a configuration so not for fixing some known problem. I do not see any issue on my side indeed with the patch applied. My understanding is that, when we adopt "fixed burst length" it is more safe to use the default burst length instead of tuning it to the maximum value. I met the same on platform driver where for performance issue and just in some cases it helped to play with AXI parameters. For sure, if somebody has different behavior I can shortly arrange the code to keep the previous setting or complete the AXI management for PCI driver (providing a default setup). Let me know what do you think. peppe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
