Hmm, we are not changing device MTU but PMTU...
thanks,
wengang
在 2016年01月06日 14:44, zhuyj 写道:
IMHO, the following comments will help us all.
case NETDEV_CHANGEMTU:
/* TODO: Should slaves be allowed to
* independently alter their MTU? For
* an active-backup bond, slaves need
* not be the same type of device, so
* MTUs may vary. For other modes,
* slaves arguably should have the
* same MTUs. To do this, we'd need to
* take over the slave's change_mtu
* function for the duration of their
* servitude.
*/
break;
Best Regards!
Zhu Yanjun
On 01/06/2016 02:32 PM, Wengang Wang wrote:
在 2016年01月06日 14:18, David Miller 写道:
From: Wengang Wang <wen.gang.w...@oracle.com>
Date: Wed, 6 Jan 2016 13:49:28 +0800
@@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4
*fl4, const struct sk_buff *skb,
const struct sock *sk)
{
const struct iphdr *iph = ip_hdr(skb);
- int oif = skb->dev->ifindex;
+ int oif;
+ struct net_device *master = NULL;
+
u8 tos = RT_TOS(iph->tos);
u8 prot = iph->protocol;
u32 mark = skb->mark;
Please fix the stlye of these variable declarations:
1) Order them from longest line to shortest line, also known
as "reverse christmas tree" layout.
2) Do not add an empty line in the middle of these variable
declarations.
OK, will do in second drop.
thanks,
wengang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
