On Wed, Jan 06, 2016 at 02:00:56AM +0100, Daniel Borkmann wrote: > > I decided to extend the sch_ingress module with clsact functionality so > that commonly used code can be reused, the module is being aliased with > sch_clsact so that it can be auto-loaded properly. Alternative would have been > to add a flag when initializing ingress to alter its behaviour plus aliasing > to a different name (as it's more than just ingress). However, the first would > end up, based on the flag, choosing the new/old behaviour by calling different > function implementations to handle each anyway, the latter would require to > register ingress qdisc once again under different alias. So, this really begs > to provide a minimal, cleaner approach to have Qdisc_ops and Qdisc_class_ops > by its own that share callbacks used by both. ... > Signed-off-by: Daniel Borkmann <dan...@iogearbox.net>
we've been going back and forth on the design and this final approach presented seems to be the best, since pros outweigh the cons. Acked-by: Alexei Starovoitov <a...@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
