Re: [RFC PATCH net-next 1/3] skbuff: export skb_gro_receive

[Marcelo Ricardo Leitner]

Em 27-01-2016 16:35, Eric Dumazet escreveu:
On Wed, 2016-01-27 at 15:06 -0200, Marcelo Ricardo Leitner wrote:
sctp GSO requires it and sctp can be compiled as a module, so export
this function.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com>
---
  net/core/skbuff.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 
b2df375ec9c2173a8132b8efa1c3062f0510284b..704b69682085dec77f3d0f990aaf0024afd705b9
 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -3312,6 +3312,7 @@ done:
        NAPI_GRO_CB(skb)->same_flow = 1;
        return 0;
  }
+EXPORT_SYMBOL_GPL(skb_gro_receive);

  void __init skb_init(void)
  {


Normally, all the offloading support belongs in vmlinux, so this export
is not needed.

For instance, we support GRO IPV6 even if IPv6 is not enabled on the
host.

Ie all these net/ipv6 files are included in vmlinux if CONFIG_INET is
enabled

ip6_offload.o tcpv6_offload.o udp_offload.o exthdrs_offload.o

Okay. For SCTP it might be a bit harder due to its CRC, which is using 
crc32c function. I'll check it.

Thanks,
Marcelo