[PATCH net-next 29/40] net: fec: don't free skb when returning busy

[Troy Kisky]

>From Documentation/networking/driver.txt

If you return NETDEV_TX_BUSY from the ndo_start_xmit method, you
must not keep any reference to that SKB and you must not attempt
to free it up.

Signed-off-by: Troy Kisky <troy.ki...@boundarydevices.com>
---
 drivers/net/ethernet/freescale/fec_main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c 
b/drivers/net/ethernet/freescale/fec_main.c
index e141f6f..3a82bfe 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -558,7 +558,6 @@ fec_enet_txq_put_data_tso(struct fec_enet_priv_tx_q *txq, 
struct sk_buff *skb,
 
        addr = dma_map_single(&fep->pdev->dev, data, size, DMA_TO_DEVICE);
        if (dma_mapping_error(&fep->pdev->dev, addr)) {
-               dev_kfree_skb_any(skb);
                if (net_ratelimit())
                        netdev_err(ndev, "Tx DMA memory map failed\n");
                return NETDEV_TX_BUSY;
@@ -616,7 +615,6 @@ fec_enet_txq_put_hdr_tso(struct fec_enet_priv_tx_q *txq,
                dmabuf = dma_map_single(&fep->pdev->dev, bufaddr,
                                        hdr_len, DMA_TO_DEVICE);
                if (dma_mapping_error(&fep->pdev->dev, dmabuf)) {
-                       dev_kfree_skb_any(skb);
                        if (net_ratelimit())
                                netdev_err(ndev, "Tx DMA memory map failed\n");
                        return NETDEV_TX_BUSY;
-- 
2.5.0