From: Eric Dumazet <eric.duma...@gmail.com> Date: Fri, 29 Jan 2016 19:23:54 -0800
> On Fri, 2016-01-29 at 18:49 -0800, Alexander Duyck wrote: >> This patch fixes an issue with unaligned accesses when using >> eth_get_headlen on a page that was DMA aligned instead of being IP aligned. >> The fact is when trying to check the length we don't need to be looking at >> the flow label so we can reorder the checks to first check if we are >> supposed to gather the flow label and then make the call to actually get >> it. >> >> Reported-by: Sowmini Varadhan <sowmini.varad...@oracle.com> >> Signed-off-by: Alexander Duyck <adu...@mirantis.com> >> --- > > > You did not quite follow the discussion Alexander, we did not exactly > took a decision about this bug. > > As we mentioned, there are other parts that need care. > > key_keyid->keyid = *keyid; > > Please address them, instead of having to 'wait' for the next crash. Indeed, this is a more fundamental issue. This change in and of itself isn't bad, and is probably a suitable micro-optimization for net-next, but it doesn't fix the bug in question.
