On 02/02/2016 01:51 PM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > > This patch allows the user to set and retrieve speed and duplex of the > virtio_net device via ethtool. Having this functionality is very helpful > for simulating different environments and also enables the virtio_net > device to participate in operations where proper speed and duplex are > required (e.g. currently bonding lacp mode requires full duplex). Custom > speed and duplex are not allowed, the user-supplied settings are validated > before applying. Only full and unknown duplex are allowed to be set. > > Example: > $ ethtool eth1 > Settings for eth1: > ... > Speed: Unknown! > Duplex: Unknown! (255) > $ ethtool -s eth1 speed 1000 duplex full > $ ethtool eth1 > Settings for eth1: > ... > Speed: 1000Mb/s > Duplex: Full > > Based on a patch by Roopa Prabhu. > > CC: Roopa Prabhu <ro...@cumulusnetworks.com> > CC: Michael S. Tsirkin <m...@redhat.com> > CC: virtualizat...@lists.linux-foundation.org > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > --- > Allowed to set unknown speed/duplex if the user wants to reset them, though > the user-space ethtool tool currently doesn't allow setting them. >
Since the speed can be anything maybe we should allow custom speeds after all ? I wasn't sure about that so I added the validation. Thanks, Nik
