> On Wed, Feb 03, 2016 at 06:15:22AM +0000, Zhang Shengju wrote: > > Replace 'goto' with 'return' to remove unnecessary check at label: > > err_undo_flags. > > I think you're going to have to explain how you came to the conclusion that > the check isn't necessary. > > -- > Jarod Wilson > ja...@redhat.com Hi Jarod,
The reason is that 'err_undo_flags' do two things for the first slave device: 1. revert bond mac address if it is set by the slave device. 2. revert bond device type if it's not ARPHRD_ETHER. I think it's not necessary for the three places, they changed neither bond mac address nor type. it's straightforward to return directly. Thanks, Shengju
