> From: Rustad, Mark D > Sent: Tuesday, February 16, 2016 9:23 AM > To: Stefan Assmann > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; > da...@davemloft.net; Brown, Aaron F > Subject: Re: [Intel-wired-lan] [PATCH net-next V2 5/6] e1000: call ndo_stop() > instead of dev_close() when running offline selftest > > > Checkpatch warns that externs should be avoided in .c files, but they > > pre-existed and are just being flagged due to the name changing, so... > > > > Tested-by: Aaron Brown <aaron.f.br...@intel.com> > > Actually, it is the forward declarations in the .c that should be deleted. > The prototypes should only exist in the .h file.
Thanks Mark, I completely missed that the patch added it to both files, too busy reviving older hardware to extend to run the diags against a larger set of parts I guess :")
