> -----Original Message----- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Thursday, February 18, 2016 8:21 PM > To: Woojung Huh - C21699; da...@davemloft.net > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause > functions > > On Fri, 2016-02-19 at 00:16 +0000, woojung....@microchip.com wrote: > > > > Ben, thanks for comments. > > > > How about comment in include/uapi/linux/ethtool.h? > > > > It says > > > > ** struct ethtool_pauseparam - Ethernet pause (flow control) > parameters > > > > ... > > > > * If @autoneg is non-zero, the MAC is configured to send and/or > > > > * receive pause frames according to the result of autonegotiation. > > > > > > > > Doesn't this mean get_pauseparam() returns pause settings based on > > > > Result of autonegotation? Not manual settings of rx_param & tx_param? > > > > > > No, get_pauseparam should return the same settings that were passed > to > > > the last set_pauseparam. > > > > > > Ben. > > > > I used drivers/net/ethernet/intel/e1000e driver as reference. > > It's implementation also returns status updated after autonegotiation. > > Look into wrong one? > > Unfortunately the API has not always been clearly defined and there are > lots of bugs (or at least inconsistencies) in drivers. The comments in > include/uapi/linux/ethtool.h are supposed to be definitive; if they are > not clear then please suggest additional or alternative wording.
I will update and repost it. BTW, do you know which driver is implemented set/get_pauseparam() correctly? Thanks.
