In the original series drivers would get offload requests for cls_u32
rules even if the feature bit is disabled. This meant the driver had
to do a boiler plate check on the feature bit before adding/deleting
the rule.

This patch lifts the check into the core code and removes it from the
driver specific case.

Signed-off-by: John Fastabend <john.r.fastab...@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    3 ---
 net/sched/cls_u32.c                           |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index cf4b729..b893ff8 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -8400,9 +8400,6 @@ int __ixgbe_setup_tc(struct net_device *dev, u32 handle, 
__be16 proto,
 
        if (TC_H_MAJ(handle) == TC_H_MAJ(TC_H_INGRESS) &&
            tc->type == TC_SETUP_CLSU32) {
-               if (!(dev->features & NETIF_F_HW_TC))
-                       return -EINVAL;
-
                switch (tc->cls_u32->command) {
                case TC_CLSU32_NEW_KNODE:
                case TC_CLSU32_REPLACE_KNODE:
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 1f31929..f766bcb 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -427,6 +427,9 @@ static int u32_delete_key(struct tcf_proto *tp, struct 
tc_u_knode *key)
 
 static bool u32_should_offload(struct net_device *dev)
 {
+       if (!(dev->features & NETIF_F_HW_TC))
+               return false;
+
        return dev->netdev_ops->ndo_setup_tc;
 }
 

Reply via email to