On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: >> - int (*walk)(struct sk_buff *, struct netlink_callback *, int, >> struct tc_action *); >> + int (*walk)(struct net *, struct sk_buff *, >> + struct netlink_callback *, int, struct tc_action >> *); >> +}; >> + > > > Do you really need to pass struct net to walk(); is deriving from skb > not sufficient?
Unfortunately, we have to pass it to walk(), because tca_action_flush() allocates the skb without setting sk, so we can't get net from skb. rtnetlink_send() accepts both net and skb too. So, overall, all of your concerns with regarding to v2 are answered, can I have your Acked-by now? ;) Thanks.
