On Mon, Feb 29, 2016 at 10:50 AM, Daniel Borkmann <dan...@iogearbox.net> wrote:
> On 02/28/2016 05:19 AM, Cong Wang wrote:
>>
>> After commit 52bd2d62ce67 ("net: better skb->sender_cpu and skb->napi_id
>> cohabitation")
>> skb_sender_cpu_clear() becomes empty and can be removed.
>>
>> Cc: Eric Dumazet <eduma...@google.com>
>> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
>
>
> Wasn't the intention to keep this helper as a marker when packet
> crosses domains from RX to TX, see discussion here:
>
> https://patchwork.ozlabs.org/patch/527167/
>
> Maybe better to rename it and add a comment into the helper to
> make the intention more clear?
Since when we need an empty function to mark some call path?
Isn't this supposed to be done by comments or documents?
BTW, I myself even don't think we need any comment, people
who touches it should understand it.
