On Mon, 2016-02-29 at 17:09 -0500, David Miller wrote: > From: Simon Xiao <six...@microsoft.com> > Date: Thu, 25 Feb 2016 15:24:08 -0800 > > > This patch allows the user to set and retrieve speed and duplex of the > > hv_netvsc device via ethtool. > > > > Example: > > $ ethtool eth0 > > Settings for eth0: > > ... > > Speed: Unknown! > > Duplex: Unknown! (255) > > ... > > $ ethtool -s eth0 speed 1000 duplex full > > $ ethtool eth0 > > Settings for eth0: > > ... > > Speed: 1000Mb/s > > Duplex: Full > > ... > > > > This is based on patches by Roopa Prabhu and Nikolay Aleksandrov. > > > > Signed-off-by: Simon Xiao <six...@microsoft.com> > > Applied, thanks.
I missed this due to flu, but now I look at it - I don't see the point. Link speed isn't meaingful for a memory-based transport, so "unknown" is correct. The link is effectively full duplex though. If the issue is that ethtool is a bit shouty about unknowns, let's consider changing that in ethtool, not teaching drivers to lie. Ben. -- Ben Hutchings If God had intended Man to program, we'd have been born with serial I/O ports.
signature.asc
Description: This is a digitally signed message part
