> From: Intel-wired-lan [intel-wired-lan-boun...@lists.osuosl.org] on behalf of
> Doron Shikmoni [doron.shikm...@gmail.com]
> Sent: Tuesday, February 16, 2016 11:34 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] igb: Garbled output for "ethtool -m"
>
> Hello,
>
> Garbled output for "ethtool -m ethX", in igb-driven NICs with module /
> plugin EEPROM (i.e. SFP information). Each output data byte appears
> duplicated.
>
> In igb_ethtool.c, igb_get_module_eeprom() is reading the EEPROM via i2c;
> the eeprom offset for each word that's read via igb_read_phy_reg_i2c()
> was passed in #words, whereas it needs to be a byte offset.
> This patches fixes the bug.
>
> Signed-off-by: Doron Shikmoni <doron.shikm...@gmail.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Checkpatch complains that you pushed the line over 80 characters:
------------------------
u1463:[0]/usr/src/kernels/next-queue> git format-patch $item -1
--stdout|./scripts/checkpatch.pl -
WARNING: line over 80 characters
#29: FILE: drivers/net/ethernet/intel/igb/igb_ethtool.c:3010:
+ status = igb_read_phy_reg_i2c(hw, (first_word + i) * 2,
&dataword[i]);
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
Your patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
u1463:[0]/usr/src/kernels/next-queue>
------------------------
But functionally seems good. I'll let Jeff choose whether to be a stickler for
the warning or not, so...
Tested-by: Aaron Brown <aaron.f.br...@intel.com>
