On Tue, 2016-03-01 at 16:20 +0100, Nicolas Dichtel wrote: > DIV_ROUND_UP and is defined in linux/kernel.h only for the kernel. [...]
But what happens when another UAPI header wants to use DIV_ROUND_UP()? Do we duplicate the definition there as well? It seems cleaner to do something like: --- a/include/uapi/linux/kernel.h +++ b/include/uapi/linux/kernel.h +#define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) --- a/include/linux/kernel.h +++ b/include/linux/kernel.h -#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) +#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP and then in include/uapi/linux/ethtool.h, replace DIV_ROUND_UP with __KERNEL_DIV_ROUND_UP throughout. Ben. -- Ben Hutchings If God had intended Man to program, we'd have been born with serial I/O ports.
signature.asc
Description: This is a digitally signed message part
