Send Netdot-devel mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://osl.uoregon.edu/mailman/listinfo/netdot-devel
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Netdot-devel digest..."
Today's Topics:
1. [SCM] Netdot branch netdot-1.0 updated.
netdot-1.0.4-93-g96926a1 ([email protected])
2. [SCM] Netdot branch master updated. netdot-1.0.4-93-g96926a1
([email protected])
----------------------------------------------------------------------
Message: 1
Date: Tue, 17 Sep 2013 06:41:08 -0700
From: [email protected]
Subject: [Netdot-devel] [SCM] Netdot branch netdot-1.0 updated.
netdot-1.0.4-93-g96926a1
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netdot".
The branch, netdot-1.0 has been updated
via 96926a12c04d75dc1305603443e50afaabafa41c (commit)
via 71c242fffd95f255c9fb0bfc5b483783dce700a8 (commit)
from 22df6890a09e607d4ab2105eca822168f579ff5b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 96926a12c04d75dc1305603443e50afaabafa41c
Author: Carlos Vicente <[email protected]>
Date: Tue Sep 17 09:40:53 2013 -0400
Correction
diff --git a/lib/Netdot/Model/ASN.pm b/lib/Netdot/Model/ASN.pm
index 11b87c8..660a2f0 100644
--- a/lib/Netdot/Model/ASN.pm
+++ b/lib/Netdot/Model/ASN.pm
@@ -94,9 +94,10 @@ sub update{
sub _validate {
my ($self, $args) = @_;
- my $num = $args->{number};
- if ( $num < 1 || $num > 4294967295 ){
- $self->throw_user("Invalid AS number: $num");
+ if ( my $num = $args->{number} ){
+ if ( $num < 1 || $num > 4294967295 ){
+ $self->throw_user("Invalid AS number: $num");
+ }
}
if ( my $rir = $args->{rir} ){
commit 71c242fffd95f255c9fb0bfc5b483783dce700a8
Author: Carlos Vicente <[email protected]>
Date: Thu Aug 29 22:15:06 2013 -0400
More specific error message in device.html
diff --git a/htdocs/management/device.html b/htdocs/management/device.html
index 7201a01..83fce20 100644
--- a/htdocs/management/device.html
+++ b/htdocs/management/device.html
@@ -171,13 +171,16 @@ if( $deviceadd && $newhost ){
$o = Device->retrieve($id);
}
-if ( $o && $o->name ){
- $name = (defined $o->name->name) ? $o->name->name : "Name N/A!";
- $fqdn = $name . "." . $o->name->zone->name;
+if ( $o ){
$id = $o->id;
-
+ if ( $o->name ){
+ $name = (defined $o->name->name) ? $o->name->name : "Name N/A!";
+ $fqdn = $name . "." . $o->name->zone->name;
+ }else{
+ $m->comp('/generic/error.mhtml', error=>"Device name not set");
+ }
}elsif ( ! $search ){
- $m->comp('/generic/error.mhtml', error=>"Device undefined or no name set");
+ $m->comp('/generic/error.mhtml', error=>"Cannot retrieve device");
}
if ( $view eq "Interfaces" || $view eq "Topology" || $view eq "All" ){
-----------------------------------------------------------------------
Summary of changes:
htdocs/management/device.html | 13 ++++++++-----
lib/Netdot/Model/ASN.pm | 7 ++++---
2 files changed, 12 insertions(+), 8 deletions(-)
hooks/post-receive
--
Netdot
------------------------------
Message: 2
Date: Tue, 17 Sep 2013 06:42:03 -0700
From: [email protected]
Subject: [Netdot-devel] [SCM] Netdot branch master updated.
netdot-1.0.4-93-g96926a1
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netdot".
The branch, master has been updated
via 96926a12c04d75dc1305603443e50afaabafa41c (commit)
via 71c242fffd95f255c9fb0bfc5b483783dce700a8 (commit)
from 22df6890a09e607d4ab2105eca822168f579ff5b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
htdocs/management/device.html | 13 ++++++++-----
lib/Netdot/Model/ASN.pm | 7 ++++---
2 files changed, 12 insertions(+), 8 deletions(-)
hooks/post-receive
--
Netdot
------------------------------
_______________________________________________
Netdot-devel mailing list
[email protected]
https://osl.uoregon.edu/mailman/listinfo/netdot-devel
End of Netdot-devel Digest, Vol 78, Issue 2
*******************************************
