Send Netdot-devel mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://osl.uoregon.edu/mailman/listinfo/netdot-devel
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Netdot-devel digest..."
Today's Topics:
1. Re: missing column in Site table? (Phil Regnauld)
2. Re: missing column in Site table? (William Bulley)
3. Re: missing column in Site table? (Phil Regnauld)
4. Re: missing column in Site table? (William Bulley)
5. Re: missing column in Site table? (Carlos Vicente)
6. Re: missing column in Site table? (William Bulley)
----------------------------------------------------------------------
Message: 1
Date: Thu, 13 Mar 2014 19:26:49 +0000
From: Phil Regnauld <[email protected]>
Subject: Re: [Netdot-devel] missing column in Site table?
To: William Bulley <[email protected]>
Cc: Carlos Vicente <[email protected]>,
[email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
William Bulley (web) writes:
> According to Phil Regnauld <[email protected]> on Thu, 03/13/14 at 13:56:
> >
> > You could submit a patch as an issue, it facilitates integration
> > and leaves a trace :)
>
> Thanks. Good point. Could you give some advice as to the best way
> to do that? To me a patch is a context diff (or a git diff) between
> two files. In this case the two files are the "before" and "after"
> states of the same file. In this case that file is the etc/netdot.meta
> file. Would that suffice?
That would work, yes!
> Thanks again. :-)
No problem - Carlos' suggestion is the correct one (fork in github).
But if you'd rather not go that path, submit a patch via an issue,
and that can be applied by a developer.
------------------------------
Message: 2
Date: Thu, 13 Mar 2014 16:40:18 -0400
From: William Bulley <[email protected]>
Subject: Re: [Netdot-devel] missing column in Site table?
To: Phil Regnauld <[email protected]>
Cc: Carlos Vicente <[email protected]>,
[email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
According to Phil Regnauld <[email protected]> on Thu, 03/13/14 at 15:26:
>
> That would work, yes!
>
> No problem - Carlos' suggestion is the correct one (fork in github).
> But if you'd rather not go that path, submit a patch via an issue,
> and that can be applied by a developer.
I grabbed the latest copy of the etc/netdot.meta file off the repository
link at Oregon.
So here is the context diff:
--- repository.etc.netdot.meta.txt 2014-03-13 16:31:07.000000000 -0400
+++ changed.etc.netdot.meta.txt 2014-03-13 16:34:37.000000000 -0400
@@ -7365,10 +7365,18 @@
length => '64',
nullable => 1,
tag => 'Country',
type => 'varchar'
},
+ description => {
+ default => '',
+ description => 'Location Details',
+ length => '255',
+ nullable => 1,
+ tag => 'Location Details',
+ type => 'varchar'
+ },
gsf => {
default => '',
description => 'Gross Square Footage of this site',
length => '',
nullable => 1,
@@ -7469,10 +7477,11 @@
unique => [ ['name'], ['number'] ],
views => {
all => [
'name',
'number',
+ 'description',
'gsf',
'aliases',
'street1',
'street2',
'pobox',
Note that I have not made any code changes to display or initialize
this column of the Site table. I don't think an extra column in an
existing table such as this column will break any existing code. :-)
Regards,
web...
--
William Bulley Email: [email protected]
72 characters width template ----------------------------------------->|
------------------------------
Message: 3
Date: Thu, 13 Mar 2014 23:55:29 +0000
From: Phil Regnauld <[email protected]>
Subject: Re: [Netdot-devel] missing column in Site table?
To: William Bulley <[email protected]>
Cc: Carlos Vicente <[email protected]>,
[email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
William Bulley (web) writes:
>
> Note that I have not made any code changes to display or initialize
> this column of the Site table. I don't think an extra column in an
> existing table such as this column will break any existing code. :-)
Indeed, it shouldn't - but for the sake of consistency, we'd obviously
need to have the templates that display and manipulate the data updated
as well - otherwise that change by itself doesn't make a lot of sense :)
------------------------------
Message: 4
Date: Thu, 13 Mar 2014 23:00:08 -0400
From: William Bulley <[email protected]>
Subject: Re: [Netdot-devel] missing column in Site table?
To: Phil Regnauld <[email protected]>
Cc: Carlos Vicente <[email protected]>,
[email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
According to Phil Regnauld <[email protected]> on Thu, 03/13/14 at 19:55:
>
> Indeed, it shouldn't - but for the sake of consistency, we'd obviously
> need to have the templates that display and manipulate the data updated
> as well - otherwise that change by itself doesn't make a lot of sense :)
I plan to be investigating that area tomorrow as a matter of fact! :-)
If the Site tab isn't overly specialized, then the generic/view.html
method of editing (updating/adding a new row) a Site should "just work"
but that doesn't necessarily cover every place where a Site is used.
It makes a sense in what I am trying to accomplish since I am adding
local features (tables and UI pages) to Netdot that needed this column.
Regards,
web...
--
William Bulley Email: [email protected]
72 characters width template ----------------------------------------->|
------------------------------
Message: 5
Date: Fri, 14 Mar 2014 12:27:51 -0400
From: Carlos Vicente <[email protected]>
Subject: Re: [Netdot-devel] missing column in Site table?
To: William Bulley <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
The problem with sending diffs to the mailing list is that there is a higher
chance that they will be forgotten.
If you are not going to do a pull request through Github, then the preferred
way is to create a ticket (issue) in Redmine, and upload the diff.
cv
On Mar 13, 2014, at 4:40 PM, William Bulley <[email protected]> wrote:
> According to Phil Regnauld <[email protected]> on Thu, 03/13/14 at 15:26:
>>
>> That would work, yes!
>>
>> No problem - Carlos' suggestion is the correct one (fork in github).
>> But if you'd rather not go that path, submit a patch via an issue,
>> and that can be applied by a developer.
>
> I grabbed the latest copy of the etc/netdot.meta file off the repository
> link at Oregon.
>
> So here is the context diff:
>
> --- repository.etc.netdot.meta.txt 2014-03-13 16:31:07.000000000 -0400
> +++ changed.etc.netdot.meta.txt 2014-03-13 16:34:37.000000000 -0400
> @@ -7365,10 +7365,18 @@
> length => '64',
> nullable => 1,
> tag => 'Country',
> type => 'varchar'
> },
> + description => {
> + default => '',
> + description => 'Location Details',
> + length => '255',
> + nullable => 1,
> + tag => 'Location Details',
> + type => 'varchar'
> + },
> gsf => {
> default => '',
> description => 'Gross Square Footage of this site',
> length => '',
> nullable => 1,
> @@ -7469,10 +7477,11 @@
> unique => [ ['name'], ['number'] ],
> views => {
> all => [
> 'name',
> 'number',
> + 'description',
> 'gsf',
> 'aliases',
> 'street1',
> 'street2',
> 'pobox',
>
> Note that I have not made any code changes to display or initialize
> this column of the Site table. I don't think an extra column in an
> existing table such as this column will break any existing code. :-)
>
> Regards,
>
> web...
>
> --
> William Bulley Email: [email protected]
>
> 72 characters width template ----------------------------------------->|
------------------------------
Message: 6
Date: Fri, 14 Mar 2014 13:26:38 -0400
From: William Bulley <[email protected]>
Subject: Re: [Netdot-devel] missing column in Site table?
To: Carlos Vicente <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
According to Carlos Vicente <[email protected]> on Fri, 03/14/14 at 12:27:
>
> The problem with sending diffs to the mailing list is that there
> is a higher chance that they will be forgotten.
>
> If you are not going to do a pull request through Github, then the
> preferred way is to create a ticket (issue) in Redmine, and upload the diff.
Thanks.
I will check out creating a ticket in Redmine, but I've not had any
expeience with it. Hopefully it is fairly straightforward to learn
how to do this. It probably won't be today since the day is almost
gone here in Michigan. :-)
Regards,
web...
--
William Bulley Email: [email protected]
72 characters width template ----------------------------------------->|
------------------------------
_______________________________________________
Netdot-devel mailing list
[email protected]
https://osl.uoregon.edu/mailman/listinfo/netdot-devel
End of Netdot-devel Digest, Vol 84, Issue 4
*******************************************
