Send Netdot-devel mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://osl.uoregon.edu/mailman/listinfo/netdot-devel
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Netdot-devel digest..."
Today's Topics:
1. [SCM] Netdot branch netdot-1.0 updated.
netdot-1.0.5-rc1-16-gea0b52f ([email protected])
2. [Netdot - Bug #1737] (Resolved) PTR record not properly
updated when changing Ipblock across reverse DNS zones
([email protected])
3. [SCM] Netdot branch netdot-1.0 updated.
netdot-1.0.5-rc1-18-gca12d72 ([email protected])
4. [SCM] Netdot branch master updated.
netdot-1.0.5-rc1-18-gca12d72 ([email protected])
5. [Netdot - Bug #1796] (Resolved) Authorization issues
([email protected])
6. [SCM] Netdot annotated tag netdot-1.0.5 created. netdot-1.0.5
([email protected])
7. [Netdot] 'OlderVersions' wiki page has been updated
([email protected])
8. [Netdot] 'DownLoad' wiki page has been updated
([email protected])
9. [Netdot] '105 ChangeLog' wiki page has been updated
([email protected])
10. [Netdot] 'OlderVersions' wiki page has been updated
([email protected])
11. [Netdot] '105 ChangeLog' wiki page has been updated
([email protected])
12. [Netdot] '105 ChangeLog' wiki page has been updated
([email protected])
----------------------------------------------------------------------
Message: 1
Date: Fri, 4 Apr 2014 12:33:30 -0700
From: [email protected]
Subject: [Netdot-devel] [SCM] Netdot branch netdot-1.0 updated.
netdot-1.0.5-rc1-16-gea0b52f
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netdot".
The branch, netdot-1.0 has been updated
via ea0b52fd423bc6b7eb3aeee05fb6257e13deb5b5 (commit)
from 17970caeb667ced8deff15fca0bdbd803ef2d147 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ea0b52fd423bc6b7eb3aeee05fb6257e13deb5b5
Author: Carlos Vicente <[email protected]>
Date: Fri Apr 4 15:32:58 2014 -0400
Fix for Bug #1737 (PTR record not properly updated when changing Ipblock
across reverse DNS zones)
diff --git a/lib/Netdot/Model/Ipblock.pm b/lib/Netdot/Model/Ipblock.pm
index b5d0397..f8d2b4b 100644
--- a/lib/Netdot/Model/Ipblock.pm
+++ b/lib/Netdot/Model/Ipblock.pm
@@ -1664,11 +1664,18 @@ sub update {
# Update PTR records if needed
if ( $self->address ne $bak{address} ){
my $name = RRPTR->get_name(ipblock=>$self);
+ # If address changed it might belong to another reverse zone.
+ my $reverse_zone = $self->reverse_zone();
foreach my $pr ( $self->ptr_records ){
my $rr = $pr->rr;
- my $domain = $rr->zone->name;
- $name =~ s/\.$domain\.?$//i;
- $rr->update({name=>$name});
+ if ( defined $reverse_zone ) {
+ my $domain = $reverse_zone->name;
+ $name =~ s/\.$domain\.?$//i;
+ $rr->update({name=>$name, zone=>$reverse_zone});
+ }else{
+ # If there's no reverse zone, the RR has no purpose
+ $rr->delete();
+ }
}
}
-----------------------------------------------------------------------
Summary of changes:
lib/Netdot/Model/Ipblock.pm | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
hooks/post-receive
--
Netdot
------------------------------
Message: 2
Date: Fri, 4 Apr 2014 12:34:32 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot - Bug #1737] (Resolved) PTR record not
properly updated when changing Ipblock across reverse DNS zones
To: [email protected], [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Issue #1737 has been updated by Carlos Vicente.
Category set to IPManagement
Status changed from New to Resolved
Assignee set to Carlos Vicente
Target version set to 1.0.5
Resolution set to fixed
Fix has been committed. Thank you!
cv
----------------------------------------
Bug #1737: PTR record not properly updated when changing Ipblock across reverse
DNS zones
https://osl.uoregon.edu/redmine/issues/1737#change-3162
Author: Matej Vadnjal
Status: Resolved
Priority: Normal
Assignee: Carlos Vicente
Category: IPManagement
Target version: 1.0.5
Resolution: fixed
When changing Ipblock address there is a block of code in Ipblock.pm/update sub
that updates PTR record associated with that address. It works fine if the old
and new address belong to the same DNS reverse zone.
However if the new address falls in a different reverse zone than the old one
the PTR record is not updated properly.
Example:
There are two subnets:
* 10.0.0.0/24 with associated reverse zone 0.0.10.in-addr.arpa
* 192.168.0.0/24 with reverse zone 0.168.192.in-addr.arpa
There is an Ipblock with address 10.0.0.5 and status Static. It has a PTR
record that looks like this:
<pre>
name: 5
zone: [reference to 0.0.10.in-addr.arpa]
ptrdname: test.example.com
</pre>
If you change the address of the Ipblock 10.0.0.5 to 192.168.0.2 the PTR record
will look like this:
<pre>
name: 2.0.168.192.in-addr.arpa
zone: [reference to 0.0.10.in-addr.arpa]
ptrdname: test.example.com
</pre>
You would expect it to look like this:
<pre>
name: 2
zone: reference to 0.168.192.in-addr.arpa
ptrdname: test.example.com
</pre>
I've attached a patch that fixes this, though it needs some review. Mainly what
to do if the new address has no associated reverse zone.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 3
Date: Fri, 4 Apr 2014 13:05:54 -0700
From: [email protected]
Subject: [Netdot-devel] [SCM] Netdot branch netdot-1.0 updated.
netdot-1.0.5-rc1-18-gca12d72
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netdot".
The branch, netdot-1.0 has been updated
via ca12d72be2b2f0083ec17747f47e3888583f0e4b (commit)
via 71fc08d949975bea351bae22e9fe96a50e359886 (commit)
from ea0b52fd423bc6b7eb3aeee05fb6257e13deb5b5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ca12d72be2b2f0083ec17747f47e3888583f0e4b
Author: Carlos Vicente <[email protected]>
Date: Fri Apr 4 16:05:42 2014 -0400
Only Admins should be able to import zone data (See #1976)
diff --git a/htdocs/management/zone.html b/htdocs/management/zone.html
index 1d2d7b2..4ce6fe3 100644
--- a/htdocs/management/zone.html
+++ b/htdocs/management/zone.html
@@ -160,7 +160,9 @@ if ( $submit ){
<div class="containerheadright">
% if ( $manager && $manager->can($user, 'edit', $o) ){
<a href="host.html?action=new&zone=<% $id %>">[add]</a>
- <a href="zone.html?id=<% $id %>&view=bulk_import">[import]</a>
+% }
+% if ( $manager && $manager->can($user, 'access_admin_section',
'zone.html:bulk') ){
+ <a href="zone.html?id=<% $id %>&view=bulk_import">[import]</a>
% }
% if ( $view eq 'records' ){
@@ -233,6 +235,7 @@ if ( $view eq 'records' || $edit eq 'records' ){
<!-- Show Bulk Import Interface -->
% if ( $view eq 'bulk_import' ){
+% if ( $manager && $manager->can($user, 'access_admin_section',
'zone.html:bulk') ){
<p>
<div align="center">
<form action="zone.html" method="POST">
@@ -246,6 +249,7 @@ if ( $view eq 'records' || $edit eq 'records' ){
<input type="button" name="cancel_button" value="cancel"
onClick="history.go(-1);">
</form>
</div>
+% }
% }
% }
commit 71fc08d949975bea351bae22e9fe96a50e359886
Author: Carlos Vicente <[email protected]>
Date: Fri Apr 4 15:55:21 2014 -0400
Remove redundant assignment
diff --git a/htdocs/management/ip.html b/htdocs/management/ip.html
index 60ac862..9da909d 100644
--- a/htdocs/management/ip.html
+++ b/htdocs/management/ip.html
@@ -86,7 +86,6 @@ my $manager = $ui->get_permission_manager($r);
if ( $id ){
if ( $o = Ipblock->retrieve($id) ){
# Check if user can view this object
- my $manager = $ui->get_permission_manager($r);
unless ( $manager && $manager->can($user, "view", $o) ){
$m->comp('/generic/error.mhtml', error=>"You don't have permission
to view this object");
}
-----------------------------------------------------------------------
Summary of changes:
htdocs/management/ip.html | 1 -
htdocs/management/zone.html | 6 +++++-
2 files changed, 5 insertions(+), 2 deletions(-)
hooks/post-receive
--
Netdot
------------------------------
Message: 4
Date: Fri, 4 Apr 2014 13:06:20 -0700
From: [email protected]
Subject: [Netdot-devel] [SCM] Netdot branch master updated.
netdot-1.0.5-rc1-18-gca12d72
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netdot".
The branch, master has been updated
via ca12d72be2b2f0083ec17747f47e3888583f0e4b (commit)
via 71fc08d949975bea351bae22e9fe96a50e359886 (commit)
via ea0b52fd423bc6b7eb3aeee05fb6257e13deb5b5 (commit)
from 17970caeb667ced8deff15fca0bdbd803ef2d147 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
htdocs/management/ip.html | 1 -
htdocs/management/zone.html | 6 +++++-
lib/Netdot/Model/Ipblock.pm | 13 ++++++++++---
3 files changed, 15 insertions(+), 5 deletions(-)
hooks/post-receive
--
Netdot
------------------------------
Message: 5
Date: Fri, 4 Apr 2014 13:07:49 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot - Bug #1796] (Resolved) Authorization
issues
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Issue #1796 has been updated by Carlos Vicente.
Status changed from New to Resolved
Resolution set to fixed
The first item I'm not sure about.
For the second, I decided that it's too dangerous for non-Admins to import zone
data.
Closing for now.
----------------------------------------
Bug #1796: Authorization issues
https://osl.uoregon.edu/redmine/issues/1796#change-3163
Author: Carlos Vicente
Status: Resolved
Priority: Normal
Assignee: Carlos Vicente
Category: AddressTracking
Target version: 1.0.5
Resolution: fixed
Submitted by nicolatron at gmail.com in the users mailing list:
- A user with ChooseIP permission on a ipblock can create ipblocks
inside that ipblock (from the show subnet view), but cannot or edit or
delete them, and they are created by default as container thus cannot
be browsed or have IPs created inside from the drop down menu. I guess
either user shouldn't be allowed to create ipblocks at all, or should
be able to configure them after creation.
- If user has dns zone admin privileges, from the import option user
can create DNS records pointing to any IP, wether it is it inside the
subnet privileged boundaries or not, permitting the creation of
records that cannot be accesed using the dropdown menus in "IP Block
actions".
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 6
Date: Sat, 5 Apr 2014 10:52:35 -0700
From: [email protected]
Subject: [Netdot-devel] [SCM] Netdot annotated tag netdot-1.0.5
created. netdot-1.0.5
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Netdot".
The annotated tag, netdot-1.0.5 has been created
at 07df69efc3fb5cc6431331c8fb6e1a06c11f96c4 (tag)
tagging ca12d72be2b2f0083ec17747f47e3888583f0e4b (commit)
replaces netdot-1.0.5-rc1
tagged by Carlos Vicente
on Sat Apr 5 13:52:22 2014 -0400
- Log -----------------------------------------------------------------
New release
Carlos Vicente (18):
Lower log level for WHOIS query failures
When monitoring multiple IPs in a single host, make the host with the
target_ip the parent in Nagios
Correction to Pg statement in upgrade script
Correction in upgrade script
Remove deprecated method from Exporter.pm. Update Sysmon exporter to
reflect change
Fix error when trying to use 'BGP' or 'All' view options on a device
without BGP peers in device.html
Merge branch 'netdot-1.0' of
ssh://netdot.uoregon.edu//home/netdot/git/netdot into netdot-1.0
Remove references to old BinFile table. Fix audit log problem when
inserting pictures
Correction to previous commit
Fix for #1784 (Whitespaces not removed from device name in
updatedevices.pl
Fix incorrect default value for table field in meta data
Tweak defaults and nullables in datacache table
Fix default entity roles at installation time
Typo in rest/host component
Changes in rest/host to show PTR records and also delete associated DNS
and DHCP records as a transaction
Fix for Bug #1737 (PTR record not properly updated when changing Ipblock
across reverse DNS zones)
Remove redundant assignment
Only Admins should be able to import zone data (See #1976)
-----------------------------------------------------------------------
hooks/post-receive
--
Netdot
------------------------------
Message: 7
Date: Sat, 5 Apr 2014 11:00:09 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot] 'OlderVersions' wiki page has been
updated
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
The 'OlderVersions' wiki page has been updated by Carlos Vicente.
OlderVersions:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/OlderVersions
View differences:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/OlderVersions/diff/4
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 8
Date: Sat, 5 Apr 2014 11:03:16 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot] 'DownLoad' wiki page has been updated
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
The 'DownLoad' wiki page has been updated by Carlos Vicente.
DownLoad:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/DownLoad
View differences:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/DownLoad/diff/65
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 9
Date: Sat, 5 Apr 2014 11:07:58 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot] '105 ChangeLog' wiki page has been
updated
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
The '105 ChangeLog' wiki page has been updated by Carlos Vicente.
105 ChangeLog:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/105_ChangeLog
View differences:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/105_ChangeLog/diff/3
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 10
Date: Sat, 5 Apr 2014 11:09:26 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot] 'OlderVersions' wiki page has been
updated
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
The 'OlderVersions' wiki page has been updated by Carlos Vicente.
OlderVersions:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/OlderVersions
View differences:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/OlderVersions/diff/5
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 11
Date: Sat, 5 Apr 2014 11:14:01 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot] '105 ChangeLog' wiki page has been
updated
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
The '105 ChangeLog' wiki page has been updated by Carlos Vicente.
105 ChangeLog:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/105_ChangeLog
View differences:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/105_ChangeLog/diff/4
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
Message: 12
Date: Sat, 5 Apr 2014 11:16:56 -0700
From: [email protected]
Subject: [Netdot-devel] [Netdot] '105 ChangeLog' wiki page has been
updated
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
The '105 ChangeLog' wiki page has been updated by Carlos Vicente.
105 ChangeLog:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/105_ChangeLog
View differences:
https://osl.uoregon.edu/redmine/projects/netdot/wiki/105_ChangeLog/diff/5
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://osl.uoregon.edu/redmine/my/account
------------------------------
_______________________________________________
Netdot-devel mailing list
[email protected]
https://osl.uoregon.edu/mailman/listinfo/netdot-devel
End of Netdot-devel Digest, Vol 85, Issue 3
*******************************************
