On Thu, May 23, 2002 at 10:38:33AM +0200, Roberto Romano wrote: > Hello, > > I just want to report an endiannes issue found with 2.4.18+newnat running on > a PPC architecture.
this turns out to be strange, since most parts of newnat have been developed on powerpc architecture. As Jozsef already pointed out, it is the PPTP patch which is the culprit. > In old nat they both contained an union "u" of 16bits width. With newnat this > union "u" is now 32bits width. > > This breaks code where the union is still initialized with 16bits values as if > the whole union size was still equal to its "port" element. this is true, indeed. While I was aware of this, I thought I had fixed all respective code parts. Maybe something got lost before creating the final patch :( > One possible fix for this chunck of code could be: exactly true. > There is multiple places in newnat code having this issue. > Anybody else tried newnat on a big-endian arch ? Yes, newnat is running on big-endian here - but without pptp :) Are you able to provide us with a patch fixing all respective places throughout the code? This would help a lot... If you don't have the time, please tell me an I'll see what I can do. > Regards, > Rob -- Live long and prosper - Harald Welte / [EMAIL PROTECTED] http://www.gnumonks.org/ ============================================================================ GCS/E/IT d- s-: a-- C+++ UL++++$ P+++ L++++$ E--- W- N++ o? K- w--- O- M+ V-- PS++ PE-- Y++ PGP++ t+ 5-- !X !R tv-- b+++ !DI !D G+ e* h--- r++ y+(*)
