From: Liping Zhang <liping.zh...@spreadtrum.com>

Instead, we can convert invert flag and ensure it is 1 or 0.

Signed-off-by: Liping Zhang <liping.zh...@spreadtrum.com>
---
 net/netfilter/xt_cpu.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/net/netfilter/xt_cpu.c b/net/netfilter/xt_cpu.c
index c7a2e54..ca1eaaf 100644
--- a/net/netfilter/xt_cpu.c
+++ b/net/netfilter/xt_cpu.c
@@ -25,27 +25,17 @@ MODULE_DESCRIPTION("Xtables: CPU match");
 MODULE_ALIAS("ipt_cpu");
 MODULE_ALIAS("ip6t_cpu");
 
-static int cpu_mt_check(const struct xt_mtchk_param *par)
-{
-       const struct xt_cpu_info *info = par->matchinfo;
-
-       if (info->invert & ~1)
-               return -EINVAL;
-       return 0;
-}
-
 static bool cpu_mt(const struct sk_buff *skb, struct xt_action_param *par)
 {
        const struct xt_cpu_info *info = par->matchinfo;
 
-       return (info->cpu == smp_processor_id()) ^ info->invert;
+       return (info->cpu == smp_processor_id()) ^ !!info->invert;
 }
 
 static struct xt_match cpu_mt_reg __read_mostly = {
        .name       = "cpu",
        .revision   = 0,
        .family     = NFPROTO_UNSPEC,
-       .checkentry = cpu_mt_check,
        .match      = cpu_mt,
        .matchsize  = sizeof(struct xt_cpu_info),
        .me         = THIS_MODULE,
-- 
2.5.5


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to