On Tue, Mar 28, 2017 at 12:45 AM, Gargi Sharma <gs051...@gmail.com> wrote: > On Tue, Mar 28, 2017 at 12:42 AM, Pablo Neira Ayuso <pa...@netfilter.org> > wrote: >> >> On Tue, Mar 28, 2017 at 12:40:15AM +0530, Gargi Sharma wrote: >> > The struct of the type option is only used to initialise a field >> > inside the xtables_match struct and is not modified anywhere. >> > Done using Coccinelle: >> > >> > @r1 disable optional_qualifier@ >> > identifier s,i; >> > position p; >> > @@ >> > >> > static struct option i@p[] ={...}; >> > >> > @ok1@ >> > identifier r1.i; >> > expression e; >> > position p; >> > @@ >> > e = i@p >> > >> > @bad@ >> > position p != {r1.p,ok1.p}; >> > identifier r1.i; >> > @@ >> > e@i@p >> > >> > @depends on !bad disable optional_qualifier@ >> > identifier r1.i; >> > @@ >> > static >> > +const >> > struct option i[] = { ... }; >> >> Applied, thanks. >> >> You can probably have a look at ebtables.git, probably there are more >> things to constify there.
Hi Pablo, There are around 18 files being affected by this semantic patch in ebtables. Should I still send them as a single patch(since it might be difficult to review a large single patch)? Thanks! Gargi >> > Okay, I will. :) > > Thanks! > Gargi >> -- >> You received this message because you are subscribed to the Google Groups >> "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to outreachy-kernel+unsubscr...@googlegroups.com. >> To post to this group, send email to outreachy-ker...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/outreachy-kernel/20170327191239.GA18080%40salvia. >> For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html