On Wed, Aug 16, 2017 at 10:42:57PM +0200, Eric Leblond wrote: [...] > diff --git a/src/libnftables.c b/src/libnftables.c > index da1b231..9248741 100644 > --- a/src/libnftables.c > +++ b/src/libnftables.c > @@ -7,7 +7,6 @@ > * > */ > > -#include <nftables/nftables.h> > #include <string.h> > #include <errno.h> > #include <nftables.h> > @@ -18,6 +17,8 @@ > #include <libmnl/libmnl.h> > #include <mnl.h> > > +#include <nftables/nftables.h> > + > #include <unistd.h> > #include <fcntl.h>
Wat? :) BTW, someone once told me "headers shouldn't include other headers", though I sometimes doubt that was the whole truth. What do you think, is "oh, you included our lib's header too early" a bug in the library or the application? [...] > diff --git a/src/main.c b/src/main.c > index 23af38e..f863dec 100644 [...] > @@ -367,7 +362,7 @@ int main(int argc, char * const *argv) > nft->output.handle++; > break; > case OPT_ECHO: > - nft.output.echo++; > + nft->output.echo++; Rebase scars. :) Cheers, Phil -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
