Eric Leblond <e...@regit.org> wrote: Thanks a lot for working on this Eric!
> On Thu, 2017-08-17 at 10:32 +0200, Arturo Borrero Gonzalez wrote: > > On 16 August 2017 at 22:42, Eric Leblond <e...@regit.org> wrote: > > > > > > Hello, > > > > > > This patchset adds a basi high level libnftables to nftables code. > > > It is currently supporting running a command from a buffer or from > > > a file as well as batch support allowing to chain commands and > > > commit > > > them at once. > > > > > > The API is mostly using existing structures such as nft_ctx that > > > are > > > updated to contain enough information. It also adds a structure > > > dedicated to batch. > > > > > > > Great work Eric, thanks! > > > > Some comments below. > > > > > A simple program running a command is the following: > > > > > > nft_global_init(); > > > nft = nft_context_new(); > > > nft_context_set_print_func(nft, my_print, buf); > > > > ^^^ > > A minor thing: Did you evaluate merging these two? Setting the print > > function directly when allocating a new context. > > Nope but could make sense. I'd recommend to keep it like this, else we can run into problems when we need a new func. If it stays this way we can simply add nft_context_set_foo_func() instead of breaking nft_context_new() abi or adding nft_context_new2() (ugh...). > > On a side note, I remember in NFWS 2017 we discussed the possibility > > of libnftables being a separate source project, i.e a standalone > > repository. > > Now that I see your patches, what I see is that libnftables is mostly > > all the code, while nft itself is very little code. > > Still, with my Debian hat, I think that different repositories is > > good to have. > > I don't like the cascade idea with nftables -> libnftables -> libnftnl > -> libmnl that this will induce. Also this means some potential > breakage in versionning. I would also like to keep it in same repo, else i fear we will quickly have copy&paste programming... We can always split later if we think that nft and libnft have matured in a way that they are distinct after all. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
