Máté Eckl <eckl...@gmail.com> wrote: > On Fri, Jun 01, 2018 at 08:59:07PM +0200, Florian Westphal wrote: > > Máté Eckl <eckl...@gmail.com> wrote: > > > diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig > > > index d03bc5a01a70..24802a2a9a90 100644 > > > --- a/net/ipv4/netfilter/Kconfig > > > +++ b/net/ipv4/netfilter/Kconfig > > > @@ -29,7 +29,13 @@ config NF_SOCKET_IPV4 > > > tristate "IPv4 socket lookup support" > > > help > > > This option enables the IPv4 socket lookup infrastructure. This is > > > - is required by the iptables socket match. > > > + is required by the {ip,nf}tables socket match. > > > + > > > +config NF_TPROXY_IPV4 > > > + tristate "IPv4 tproxy support" > > > + help > > > + This option enables tranparent proxy support for IPv4. This is > > > required > > > + by the iptables TPROXY targer. > > > > No need for a help text; as this is just dependency glue auto-selected > > via Kconfig. > > > > Other than that, this looks good to me, thank you. > > If you don't insist on removing, I would keep them. I think it's nice to have > some description so that users can get a clue about what this is.
I don't, but if this would be config NF_TPROXY_IPV4 tristate and nothing else then kconfig won't show this dependency anymore. And thats fine in case its auto-picked via "select" when XT_TPROXY is enabled. If "depends" is used then ignore this and keep the help text. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html