Hi Harsha, Thank you for the patch! Yet something to improve:
[auto build test ERROR on nf-next/master] url: https://github.com/0day-ci/linux/commits/Harsha-Sharma/netfilter-cttimeout-move-ctnl_untimeout-to-nf_conntrack/20180714-095352 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: i386-randconfig-x015-201827 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): net//netfilter/nfnetlink_cttimeout.c: In function 'ctnl_timeout_try_del': >> net//netfilter/nfnetlink_cttimeout.c:312:3: error: implicit declaration of >> function 'nf_ct_untimeout'; did you mean 'nf_ct_netns_put'? >> [-Werror=implicit-function-declaration] nf_ct_untimeout(net, timeout); ^~~~~~~~~~~~~~~ nf_ct_netns_put cc1: some warnings being treated as errors vim +312 net//netfilter/nfnetlink_cttimeout.c 299 300 /* try to delete object, fail if it is still in use. */ 301 static int ctnl_timeout_try_del(struct net *net, struct ctnl_timeout *timeout) 302 { 303 int ret = 0; 304 305 /* We want to avoid races with ctnl_timeout_put. So only when the 306 * current refcnt is 1, we decrease it to 0. 307 */ 308 if (refcount_dec_if_one(&timeout->refcnt)) { 309 /* We are protected by nfnl mutex. */ 310 list_del_rcu(&timeout->head); 311 nf_ct_l4proto_put(timeout->l4proto); > 312 nf_ct_untimeout(net, timeout); 313 kfree_rcu(timeout, rcu_head); 314 } else { 315 ret = -EBUSY; 316 } 317 return ret; 318 } 319 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
