Hi Harsha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on nf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Harsha-Sharma/netfilter-nft_ct-add-ct-timeout-support/20180714-095128
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> net/netfilter/nft_ct.c:1106:11: error: 'nft_ct_timeout_obj_eval' undeclared 
>> here (not in a function); did you mean 'nft_ct_timeout_obj_ops'?
     .eval  = nft_ct_timeout_obj_eval,
              ^~~~~~~~~~~~~~~~~~~~~~~
              nft_ct_timeout_obj_ops
>> net/netfilter/nft_ct.c:1107:11: error: 'nft_ct_timeout_obj_init' undeclared 
>> here (not in a function); did you mean 'nft_ct_timeout_obj_eval'?
     .init  = nft_ct_timeout_obj_init,
              ^~~~~~~~~~~~~~~~~~~~~~~
              nft_ct_timeout_obj_eval
>> net/netfilter/nft_ct.c:1108:13: error: 'nft_ct_timeout_obj_destroy' 
>> undeclared here (not in a function); did you mean 'nft_ct_timeout_obj_init'?
     .destroy = nft_ct_timeout_obj_destroy,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
                nft_ct_timeout_obj_init
>> net/netfilter/nft_ct.c:1109:11: error: 'nft_ct_timeout_obj_dump' undeclared 
>> here (not in a function); did you mean 'nft_ct_timeout_obj_init'?
     .dump  = nft_ct_timeout_obj_dump,
              ^~~~~~~~~~~~~~~~~~~~~~~
              nft_ct_timeout_obj_init

vim +1106 net/netfilter/nft_ct.c

  1101  
  1102  static struct nft_object_type nft_ct_timeout_obj_type;
  1103  static const struct nft_object_ops nft_ct_timeout_obj_ops = {
  1104          .type           = &nft_ct_timeout_obj_type,
  1105          .size           = sizeof(struct nft_ct_timeout_obj),
> 1106          .eval           = nft_ct_timeout_obj_eval,
> 1107          .init           = nft_ct_timeout_obj_init,
> 1108          .destroy        = nft_ct_timeout_obj_destroy,
> 1109          .dump           = nft_ct_timeout_obj_dump,
  1110  };
  1111  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to