On Mon, Oct 29, 2018 at 01:23:04PM +0100, Phil Sutter wrote: > On Mon, Oct 29, 2018 at 12:33:38PM +0100, Pablo Neira Ayuso wrote: > > Add NFT_CTX_OUTPUT_HANDLE flag and print handle that uniquely identify > > objects from new output flags interface. > > > > Signed-off-by: Pablo Neira Ayuso <[email protected]> > > Acked-by: Phil Sutter <[email protected]> > > One minor nit here as well: > > [...] > > diff --git a/doc/libnftables.adoc b/doc/libnftables.adoc > > index c837c2d251bc..8b7aee9af134 100644 > > --- a/doc/libnftables.adoc > > +++ b/doc/libnftables.adoc > [...] > > @@ -105,6 +103,8 @@ NFT_CTX_OUTPUT_SERVICE:: > > Print port numbers as services as described in the /etc/services file. > > NFT_CTX_OUTPUT_STATELESS:: > > If stateless output has been requested then stateful data is not > > printed. Stateful data refers to those objects that carry run-time data, > > eg. the *counter* statement holds packet and byte counter values, making it > > stateful. > > +NFT_CTX_OUTPUT_HANDLE:: > > + Upon insertion into the ruleset, some elements are assigned a unique > > handle for identification purposes. For example, when deleting a table or > > chain, it may be identified either by name or handle. Rules on the other > > hand must be deleted by handle because there is no other way to uniquely > > identify them. These functions allow to control whether ruleset listings > > should include handles or not. > > s/These functions allow/This flag allows/ > > (Or maybe rewrite the whole last sentence to read: "This flag makes > ruleset listings include handle values.")
I took this sentence. > One thing to consider given the very long line above: When writing > documentation for man pages, I've usually adhered to 80 column max > width. Though searching for asciidoc style guides I encountered an > interesting alternative approach, namely to keep each sentence in a > separate line. The rationale was to clear up diffs since no reformatting > would happen and on the other hand to easily identify overlong sentences > one might want to break into two. I don't have a strong opinion here, > just wanted to share an interesting idea. I have split long line into separed lines, thanks for suggesting this.
