On Thu, Jun 20, 2019 at 11:08:18PM +0530, shekhar sharma wrote: > On Thu, Jun 20, 2019 at 8:07 PM Pablo Neira Ayuso <pa...@netfilter.org> wrote: > > > > On Wed, Jun 19, 2019 at 11:27:41PM +0530, Shekhar Sharma wrote: > > > This patch changes the file to run on both python2 and python3. > > > > > > The tempfile module has been imported and used. > > > Although the previous replacement of cmp() by eric works, > > > I have replaced cmp(a,b) by ((a>b)-(a<b)) which works correctly. > > > > Any reason not to use Eric's approach? This ((a>b)-(a<b)) is > > confusing. > > No, Eric's approach is also working nicely. I read on a website > that cmp(a,b) of python2 can be replaced by ((a>b)-(a<b)) in python3.
This is true, but as Pablo stated it can be confusing. For this function we only care if the sets are equivalent so I simplified it. If you agree, the please drop this change from your next revision and Pablo can take my patch.
