Editing ipt_string.c the way you propossed really solved the problems.
Now kernel gets compiled with absolutely no problems.
I've redone some steps and confirmed that the problem really happens
with kernel 2.4.18 and iptables 1.2.6, despite it's supposed to be fixed.
1) downloaded and extracted linux-2.4.18.tar.bz2
2) downloaded and extracted iptables-1.2.6.tar.bz2
3) get into iptables-1.2.6 tree and make patch-o-matic pointing to
2.4.18 fresh source tree
4) applied the following patches of p-o-m ( in order ): iplimit, mport,
NETMAP, psd, time, string
5) configured kernel as usual ( all netfilter stuff are compiled as
modules )
6) make dep clean bzImage goes well
7) make modules fails with error I've sent in the first message
So, it this is supposed to be fixed, it's absolutety not ......
Please check it out and thanks very much for your reply.
Sincerily,
Leonardo Rodrigues
----- Original Message -----
From: "Jeffery P. Humes" <[EMAIL PROTECTED]>
To: "Leonardo Rodrigues" <[EMAIL PROTECTED]>
Cc: "netfilter ML" <[EMAIL PROTECTED]>
Sent: Friday, March 15, 2002 7:47 AM
Subject: Re: problems with 2.4.18 and iptables 1.2.6
> Leonardo,
>
> This problem was the supposed to be fixed.... hmmm
> at any rate here is how to "patch" it:
>
> **this is assuming you have already run the "make patch-o-matic"**
>
> 1. Use you favorite text editor to edit the ipt_string.c file.
> vi
/usr/src/<your_kernel_source_directory>/net/ipv4/netfilter/ipt_string.c
> 2. Change this line:
> right_end = max(int, right_end - i + sk, right_end + sh);
> To this:
> right_end = max(right_end - i + sk, right_end + sh);
> 3. Save the file.
> 4. Recompile the kernel
>
> Regards,
> Jeff Humes
>
> Leonardo Rodrigues wrote:
>
> > Hello Guys,
> >
> > I'm having problems compiling kernel 2.4.18 after 'make
patch-o-matic'
> > from iptables 1.2.6 tree. Seems that string module is missing something
....
> >
> >
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-tri
> >
graphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpre
> > ferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS -include
> >
usr/src/linux/include/linux/modversions.h -DKBUILD_BASENAME=ipt_string -c
> > -o ipt_string.o ipt_string.c
> > ipt_string.c:80:72: macro "max" passed 3 arguments, but takes just 2
> > ipt_string.c: In function `search_sublinear':
> > ipt_string.c:53: warning: subscript has type `char'
> > ipt_string.c:78: warning: subscript has type `char'
> > ipt_string.c:80: `max' undeclared (first use in this function)
> > ipt_string.c:80: (Each undeclared identifier is reported only once
> > ipt_string.c:80: for each function it appears in.)
> > make[2]: *** [ipt_string.o] Error 1
> > make[2]: Leaving directory `/usr/src/linux/net/ipv4/netfilter'
> > make[1]: *** [_modsubdir_ipv4/netfilter] Error 2
> > make[1]: Leaving directory `/usr/src/linux/net'
> > make: *** [_mod_net] Error 2
