(Resending, apologies in case of duplicates) I have reviewed some parts of the draft and have just a few comments as well:
- One area where guidelines are missing, but where guidance would be needed, concerns how to model return values from RPCs, as well as how to model the handling of RPC error conditions. This is an area where I think YANG itself could need some improvement, and in its absence good guidelines would be even more important. - It would be also useful to provide guidelines regarding how to augment/extend groupings. This is a common scenario and what to do is not necessarily intuitive, so I am sure many users would appreciate guidelines here. - Section 3.4: It would be good to provide a guideline regarding lines that exceed 70 columns (from the pyang tree output), at least mention that authors need to manually address this issue - Section 3.7: Personally, I think the security considerations as currently stated, while well-intended, introduce a bit too much red tape. Specifically, this concerns having to list nodes individually - this can lead to defining many "trees" while missing the "forest". The guidelines are a bit "rubbery" here, by the way, stating that data nodes MUST be individually listed and discussed, at the same time only if they "could be especially disruptive" - what does that mean - so maybe the requirement should simply be a "SHOULD" here? - Observation: there is no mention/guideline canonical order of YANG statements. Thanks --- Alex -----Original Message----- From: netmod [mailto:netmod-boun...@ietf.org] On Behalf Of Kent Watsen Sent: Tuesday, September 12, 2017 11:22 AM To: netmod@ietf.org Cc: netmod-cha...@ietf.org; draft-ietf-netmod-rfc6087...@ietf.org Subject: [netmod] WG Last Call: draft-ietf-netmod-rfc6087bis-14 This starts a two-week working group last call on: Guidelines for Authors and Reviewers of YANG Data Model Documents https://tools.ietf.org/html/draft-ietf-netmod-rfc6087bis-14 Please send email to the list indicating your support or concerns. We are particularly interested in statements of the form: * I have reviewed this draft and found no issues. * I have reviewed this draft and found the following issues: ... Thank you, NETMOD WG Chairs _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod