Hi,
I have read this document and think that is almost ready for publication.
I have one general comment regarding the YANG module library (at the
end), and a few nits, but otherwise the draft looks good.
1. Sec 1. Introduction paragraph 2, "internal node". It wasn't
absolutely clear to me what an internal node is, so I wonder whether
this would be more clear as "internal (i.e. non root) node".
2. Sec 1. Introduction, page 4, paragraph starting "2.
Implementation-time ...". This section states that it is a stable as
YANG library, and hence cannot change due to a server reboot. However,
YANG library doesn't appear to have that restriction, and hence this
doesn't seem to align with RFC 7895, introduction paragraph 2.
3. Sec 2.1 Glossary of New Terms: "Schema" isn't actually defined
anywhere (RFC 7950 doesn't define this). Should it be defined here?
The NMDA datastores draft had a similar issue and we choose to define
"datastore schema" instead.
4. Sec 3.2. paragraph 1. Same comment as 2 above also applies here.
The text "same management session" might be more clear as "same client
management protocol session".
5. Sec 3.2. paragraph 2, last sentence: "are possible and such needs" =>
"are possible, and as such, needs"
6. Sec 3.2 paragraph 5. Would it useful to state that even though the
schema is the same, the data is different and not necessarily related.
7. Sec 3.3 last paragraph. "On the other hand, " => "In addition, "
8. Sec 6 Implementation Notes. Would this section be better named
"Implementation Considerations"?
9. Structure of ietf-yang-schema-mount module:
- Should "uri" under namespace be marked as "mandatory" so that it
doesn't appear to be optional in the tree diagram.
- Should the "module" name be included under the namespace. It seems
that lots of other "module bindings" are done via the module name rather
than the namespace?
10. Example A.3. This contains some features that are enabled. Possibly
it would be useful in the description to point this out, and state that
unless the features are listed they wouldn't be enabled.
My last general comment relates generally to the structure of the
Iietf-yang-schema-mount. As Lada has pointed out previously, this
module and YANG library bis could be more closely aligned (e.g. along
the lines of reusing module-sets for the "schema" list). It would have
been nice if this module could augment YANG library (so that you can
easily get the modules and schema mount information in a single simple
request), however that would put an undesired dependency delaying
publishing this draft until YANG library bis is completed.
Thanks,
Rob
On 20/10/2017 22:37, Kent Watsen wrote:
All,
This starts a two-week working group last call on
draft-ietf-netmod-schema-mount-07.
The working group last call ends on November 3.
Please send your comments to the netmod mailing list.
Positive comments, e.g., "I've reviewed this document
and believe it is ready for publication", are welcome!
This is useful and important, even from authors.
Could the authors, explicitly CC-ed on this email,
please also confirm one more time that they are
unaware of any IPR related to this draft.
Thank you,
Netmod Chairs
_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod
.
_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod
