Kristian, As I commented on the PR, putting the ‘container’ inside of the ‘choice’ statement allows me to collapse the ‘container’ and the ‘case’ statement into a single ‘container’ statement. With your changes, I see an additional ‘case’ statement, bloating the model in four places.
Cheers. > On Feb 6, 2018, at 1:42 AM, Kristian Larsson <krist...@spritelink.net> wrote: > > Mahesh, > > I suppose, since you posted the update Friday night, that I missed my chance > of prettifying the source/destination port choice/container structure that > was just added. If not, it's in a PR towards your repo - > https://github.com/mjethanandani/acl-model/pull/4 > > Kind regards, > Kristian. > > > > On 2018-02-03 02:41, Mahesh Jethanandani wrote: >> This update addresses the comments that were received as part of LC. For >> those of you who commented on the draft during the LC, please verify that >> your comments have been addressed. >> Thanks. >>> On Feb 2, 2018, at 5:26 PM, internet-dra...@ietf.org wrote: >>> >>> >>> A New Internet-Draft is available from the on-line Internet-Drafts >>> directories. >>> This draft is a work item of the Network Modeling WG of the IETF. >>> >>> Title : Network Access Control List (ACL) YANG Data Model >>> Authors : Mahesh Jethanandani >>> Lisa Huang >>> Sonal Agarwal >>> Dana Blair >>> Filename : draft-ietf-netmod-acl-model-16.txt >>> Pages : 54 >>> Date : 2018-02-02 >>> >>> Abstract: >>> This document describes a data model of Access Control List (ACL) >>> basic building blocks. >>> >>> Editorial Note (To be removed by RFC Editor) >>> >>> This draft contains many placeholder values that need to be replaced >>> with finalized values at the time of publication. This note >>> summarizes all of the substitutions that are needed. Please note >>> that no other RFC Editor instructions are specified anywhere else in >>> this document. >>> >>> Artwork in this document contains shorthand references to drafts in >>> progress. Please apply the following replacements >>> >>> o "XXXX" --> the assigned RFC value for this draft both in this >>> draft and in the YANG models under the revision statement. >>> >>> o Revision date in model needs to get updated with the date the >>> draft gets approved. The date also needs to get reflected on the >>> line with <CODE BEGINS>. >>> >>> >>> The IETF datatracker status page for this draft is: >>> https://datatracker.ietf.org/doc/draft-ietf-netmod-acl-model/ >>> >>> There are also htmlized versions available at: >>> https://tools.ietf.org/html/draft-ietf-netmod-acl-model-16 >>> https://datatracker.ietf.org/doc/html/draft-ietf-netmod-acl-model-16 >>> >>> A diff from the previous version is available at: >>> https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-acl-model-16 >>> >>> >>> Please note that it may take a couple of minutes from the time of submission >>> until the htmlized version and diff are available at tools.ietf.org. >>> >>> Internet-Drafts are also available by anonymous FTP at: >>> ftp://ftp.ietf.org/internet-drafts/ >>> >>> _______________________________________________ >>> netmod mailing list >>> netmod@ietf.org >>> https://www.ietf.org/mailman/listinfo/netmod >> Mahesh Jethanandani >> mjethanand...@gmail.com >> _______________________________________________ >> netmod mailing list >> netmod@ietf.org >> https://www.ietf.org/mailman/listinfo/netmod > > _______________________________________________ > netmod mailing list > netmod@ietf.org > https://www.ietf.org/mailman/listinfo/netmod Mahesh Jethanandani mjethanand...@gmail.com _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod
