Hi Med,
On Friday, January 24, 2025 at 10:47:06 AM EST,
<[email protected]> wrote:
Re-,
ha ha ha
No using a default statement does not meant that a system does not have a
default value.
<RR> Understood. One example is cases where the default is complex or
conditional, e.g. interface MTU depends on iftype.
Using a default yang statement to formally record this is problematic for our
reusable grouping. Let’s consider the following example:
List template (key id, uses recurrence-basic)
List rule (key name, leaf template-ref, uses recurrence-basic)
Let’s assume that the interval is customized in a template and that template is
referenced in a rule. That customized value will be overridden by the default
of the interval at the rule level.
<RR> I understand why default statements in groupings can be problematic. What
I still don't understand is why have the description mention a default when
there is no default statement, it is unusual. Possible I just don't understand
the problem you're addressing. Anyway I've made my point, up to the WG. And if
no-one makes any comments on this, feel free to ignore me.
Regards,Reshad.
Hope this is better.
Cheers,
Med
De : Reshad Rahman <[email protected]>
Envoyé : vendredi 24 janvier 2025 16:31
À : [email protected]; maqiufang (A) <[email protected]>; BOUCADAIR
Mohamed INNOV/NET <[email protected]>
Cc : [email protected]; [email protected]
Objet : Re: Yangdoctors last call review of draft-ietf-netmod-schedule-yang-03
Hi Med, authors,
TBH I am confused. Why remove the default statement but keep mention of it in
the description... Is there a default or is there no default?
Or is this Schrödinger's cat, maybe that's why I am confused :-)
Regards,
Reshad.
On Friday, January 24, 2025 at 09:43:56 AM EST, <[email protected]>
wrote:
Hi Reshad,
When we decided to remove the default statement, we thought that it is helpful
to remind the default as currently defined in 3.3.10 of 5545:
The default value is
"1", meaning every second for a SECONDLY rule, every minute for a
MINUTELY rule, every hour for an HOURLY rule, every day for a
DAILY rule, every week for a WEEKLY rule, every month for a
MONTHLY rule, and every year for a YEARLY rule.
Do you see a harm in having that text? Thanks.
Cheers,
Med
De : Reshad Rahman <[email protected]>
Envoyé : vendredi 24 janvier 2025 15:37
À : [email protected]; maqiufang (A) <[email protected]>
Cc : [email protected];[email protected]
Objet : Re: Yangdoctors last call review of draft-ietf-netmod-schedule-yang-03
Hi Qiufang, authors,
I am good with the changes made. I understand why default values can be
undesirable in groupings.
My only remaining comment/question is why keep mention of default value in the
description?
Regards,
Reshad.
leaf interval { type uint32; description
"A positive integer representing at which intervals the recurrence
rule repeats. For example, within a 'daily' recurrence rule, a
value of '8' means every eight days. The default value is '1',
means every second for a 'secondly' recurrence rule, every minute
for a 'minutely' rule, and so on."; }
On Friday, January 24, 2025 at 04:47:24 AM EST, maqiufang (A)
<[email protected]> wrote:
Hi, Reshad,
Thanks a lot for the comments, the authors has made some updates which is
available
at:https://author-tools.ietf.org/api/iddiff?doc_1=draft-ietf-netmod-schedule-yang&url_2=https://netmod-wg.github.io/schedule-yang/draft-ietf-netmod-schedule-yang.txt,
feel free to share your feedback. Please also see my reply below inline with
[Qiufang].
-----Original Message-----
From: Reshad Rahman via Datatracker [mailto:[email protected]]
Sent: Wednesday, January 22, 2025 7:02 AM
To: [email protected]
Cc: [email protected]; [email protected]
Subject: Yangdoctors last call review of draft-ietf-netmod-schedule-yang-03
Reviewer: Reshad Rahman
Review result: Ready with Issues
Thanks for addressing my review comments which were discussed at
https://mailarchive.ietf.org/arch/msg/netmod/AO7wvBa0gJbC-Egt_UuZHKCML70
I believe there are a couple of issues remaining, however it should be easy to
address/close them.
Issues
======
For "leaf interval", the description mentions a default value but there is no
default statement.
[Qiufang] Right, but this is intentional. The authors had some discussion
related to the default statement in the grouping, and we incline not to impact
how the groupings would be reused, and give the consumers choice of deciding
whether this should be a default or mandatory. For more context, you may find
some internal discussion athttps://github.com/netmod-wg/schedule-yang/pull/8.
Make sense?
I believe we need more mandatory statements, or default statement if
appropriate, otherwise the behaviour is unknown. For example:
[Qiufang] See my comment above, as the intention is to try not to define
mandatory/default statements in the groupings, we would like to add more
description to clarify cases where the node is unspecified.
- In "container recurrence-first", should "start-time-utc" and "duration" be
mandatory?
[Qiufang] No, they are allowed to be unspecified. The following changes are
made to the description statement of container "recurrence-first":
OLD:
description
"Specifies the first instance of the recurrence."
NEW:
description
"Specifies the first instance of the recurrence. If
unspecified, the recurrence is considered to start from the
date and time when the recurrence pattern is first
satisfied.";
- In "choice period-type", if no choice is made does that mean there is no end
to the period? If so, please add that to the description. If not, add a
mandatory statement.
[Qiufang] Sure, the following changes are made to the description:
OLD:
description
"Indicates the type of the time period. Two types are
supported."
NEW:
description
"Indicates the type of the time period. Two types are
supported. If no choice is indicated, the period is
considered to last forever or as a one-shot schedule.";
Nit: the term "recurrence rule" is used a lot in the document, but it is not
explained anywhere. In the terminology section, add a reference to 3.8.5.3 of
RFC5545?
[Qiufang] Good suggestion. The following is defined in the terminology section:
Recurrence Rule:
Refers to a rule or repeating pattern for recurring events. See also Section
3.8.5.3 of [RFC5545] for a comprehensive iCalendar recurrence rule
specification.
Regards,
Reshad.
Best Regards,
Qiufang
_________________ ______________________________
______________________________ ______________________________ _ Ce message et
ses pieces jointes peuvent contenir des informations confidentielles ou
privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans
autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a
l'expediteur et le detruire ainsi que les pieces jointes. Les messages
electroniques etant susceptibles d'alteration, Orange decline toute
responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This
message and its attachments may contain confidential or privileged information
that may be protected by law; they should not be distributed, used or copied
without authorisation. If you have received this email in error, please notify
the sender and delete this message and its attachments. As emails may be
altered, Orange is not liable for messages that have been modified, changed or
falsified. Thank you. _________________ ______________________________
______________________________ ______________________________ _
Ce message et ses pieces jointes peuvent contenir des informations
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce
message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou
falsifie. Merci.
This message and its attachments may contain confidential or privileged
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete
this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been
modified, changed or falsified.
Thank you.
_______________________________________________
netmod mailing list -- [email protected]
To unsubscribe send an email to [email protected]
