I updated draft-ietf-netmod-sub-intf-vlan-model per your review (detailed in the thread below).
Hopefully the updates are ok. I extracted the YANG and pretty printed it, and regenerated the trees. Fixed the security consideration section and various typos. Added a note to the RFC editor about the substitutions needed. https://datatracker.ietf.org/doc/draft-ietf-netmod-sub-intf-vlan-model/ Looking forward to the next step. Many thanks, -scott. -----Original Message----- From: Per Andersson <[email protected]> Sent: Tuesday, April 8, 2025 3:16 PM To: Scott Mansfield <[email protected]> Cc: [email protected]; [email protected]; [email protected] Subject: Re: Yangdoctors early review of draft-ietf-netmod-sub-intf-vlan-model-14 On Tue, Apr 8, 2025 at 6:37 PM Scott Mansfield <[email protected]> wrote: > (...) > > RFC XXXX is referenced in both ietf-if-flexible-encapsulation and > ietf-if-vlan-encapsulation for ietf-if-extensions. However, in the > descriptions and revision references it says that > ietf-if-flexible-encapsulation is part of RFC XXXX. > > The YANG module ietf-if-extensions is part of > I-D.draft-ietf-netmod-intf-ext-yang and should be referenced as such. > > <scott> > I will look to clean this up. The intf-ext-yang is in the same state as > sub-intf-vlan, so they could be considered together so we don't have to go > back in and add the RFC numbers. I'm not sure the best way to handle this, > so any suggestions are appreciated. > </scott> Use something like RFC AAAA and a section for the rfc editor at the top mentioning what RFC XXXX and RFC AAAA should reference once published. See for instance https://datatracker.ietf.org/doc/html/draft-ietf-netconf-over-quic-02 Furthermore, I believe that it is possible to ask the RFC Editor to process the documents together. (For instance, so they get subsequent numbers.) > Out of scope for this review but worth mentioning: The use of the "-grouping" > suffix in grouping identifiers is recommended to be avoided. > The YANG modules in this document does not do this, but the imported > IEEE 802.1Q YANG module does. If, by any chance, there is > collaboration on YANG modules, or liaisons participating in both IETF > and IEEE: Please forward this recommendation for future YANG modules. > :) > > <scott> > I will bring this up with the YANG coordination group in the IEEE 802.1 and > suggest a guideline. It might be a while before anything will change > however. I will also review the latest version of rfc8407bis again, good to > stay on top of that. > </scott> I understand, just thought it would be good to mention at least. :) > Thank you very much for your review. Thank you for your contribution! -- Per _______________________________________________ netmod mailing list -- [email protected] To unsubscribe send an email to [email protected]
