Document: draft-ietf-netmod-schedule-yang Title: A Common YANG Data Model for Scheduling Reviewer: Peter Yee Review result: Ready with Nits
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-netmod-schedule-yang-08 Reviewer: Peter Yee Review Date: 2025-07-05 IETF LC End Date: 2025-06-27 IESG Telechat date: 2025-08-07 Summary: As its name says, this is a YANG data model for scheduling. Fairly intricate schedules are possible using the model. I am in no way a YANG expert, so I’ve only read the document for consistency and the like. The actual module got a cursory examination as did the examples. There are some nits that should be corrected, but nothing of great import. [Ready with nits] Major issues: None Minor issues: None Nits/editorial comments: General: Some of the figure captions do not stick to the corresponding figure in the ASCII version of the document. I’m not sure if there’s anything that can be done for that. Likewise, at least one introductory description is floating on a page followed by a lot of blank space and then the YANG definition on the next page. It would be preferrable to keep them together. Specific: Page 3, section 1, 4th paragraph, last sentence: insert “the” before ‘“ietf-schedule”’. Insert “a” before resources. Page 13, section 3.3.8, 1st sentence: change “define” to “defines”. Page 14, 1st paragraph after Figure 8, 2nd sentence: I’d suggest changing “generates” to “are generated”. Page 15, 1st full paragraph, 2nd sentence: Likewise, I’d suggest changing “generates” here to “are generated”. Page 15, last paragraph, 2nd sentence: perhaps change “generated” to “created” to avoid the repetition in the sentence. Page 17, sentence after Figure 9: change “exists” to “exist”. Page 18, 2nd paragraph, 2nd sentence: change “who create” to “that created”. Page 18, 4th paragraph, 1st sentence: change “host” to “hosts”. Page 18, section 3.4, 1st paragraph, last sentence: change “depend” to “depends” and insert “the” before “specific”. Page 22, description in feature icalendar-recurrence: change “icalendar” to “iCalendar”. Page 29, leaf duration description, 1st sentence: delete “the” before “time”. Page 29, leaf duration description, 3rd sentence: change “as” to “to be”. Page 30, leaf duration description, 1st sentence: change “last” to “lasts”. Page 39, section 7, 2nd paragraph, 2nd sentence: change “and” to “or”. Page 46, paragraph after Figure 10, 1st sentence: change the comma after “(Beijing Time)” to a period. Then change “schedule” to “Schedule”. Basically, make two sentences out of the one. Page 50, section A.7, 1st paragraph, 1st sentence: change “last” to “lasts”. Delete the comma after “PM”. Insert “an” before “extra”. _______________________________________________ netmod mailing list -- [email protected] To unsubscribe send an email to [email protected]
